Help with script [JIP NVSE]

[Arkngt]

I'm trying to update my Distributed Necklaces and Chains to use the updated JIP NVSE script in Distributed Necklaces and Chains Neck Seam Concealer - Update.

It distributes necklaces to both males and females - and the relevant script parts seem to be: (Nevermind, see my attached file  instead.)

So I thought that I just could edit away the last part and have the result that only females would get necklaces. Like this:  (As above, see attached file). But with this change both sexes still get necklaces. So what am I doing wrong?   Another issue is that I get a pronounced lag when using it, which very well may be because I've butchered the script, but TJ notes this: "If this is causing you lag (it really shouldn't) or happening too much / not enough, you can open the plugin in xEdit and change the Global NaCRefTimer to whatever you'd like." What does "whatever you'd like" mean in practice? It's set at 15 in the global, so should I up or down it if I want to experiment with it - and within which parameters?  

Anyway, I suck at scripting, so if anyone can give advice on how to make it distribute only to females I'd be grateful. Here's the entire script:  

EDIT: So how can I have parts of a script in my post without messing up the entire formatting? I'll attach it as a file instead.

EDIT 2: I get no lag with the original script, so it must be my edited version that is messed up I guess.

[Gribbleshnibit8]

Did not test at all, just wrote stuff, added comments. Might need fixing, see if it's better.

[Gallahorn]

Im looking at the script TJ wrote and it should more or less just be to add a sex check in this section of the script for it to only apply to females. I think.

 

;=========Check if Actor is eligible for Neck wear=========

if ((rActor.GetItemCount NaCList >= 1) || (rActor.GetDisabled) || (rActor.GetDead))

Continue else



 

[Arkngt]

Thanks both! I'll try out the new script immediately. The comments are very helpful!

[Arkngt]

@Gribbleshnibit8, it seems to work perfectly. :) Much obliged.

[TJ]

For what it's worth, most of my scripting knowledge comes from Gribbleshnibit8. Also for simple things that are easy to add, I can give advice / help when I have time.

[Arkngt]

[quote=TJ]

 

For what it's worth, most of my scripting knowledge comes from Gribbleshnibit8. Also for simple things that are easy to add, I can give advice / help when I have time.

[/quote]

Cool. :) Is it OK if I release conversions of my variants of Distributed Necklaces etc., using your and Gribbleshnibit8's updated JIP NVSE script? I'm a bit fond of my Females Only Complete version, so I'm using that myself in the game.

[TJ]

I don't have an issue with it.

[Arkngt]

Thanks! I'll give you (and Gribbleshnibit8) credit of course. My mod is essentially a Frankenstein's Monster built with parts from other mods and authors.

[Arkngt]

So I've managed to butcher the script again. Gribbleshnibit8's edited version works perfectly, but I thought I'd use that as a base for my version that adds necklaces to both males and females. It works for males, but females don't get any necklaces. Should I use elseif instead of if for the female section? No idea, but it doesn't work as is. I'd be grateful if someone points out the glaring mistake I'm sure it has: