My First Time Scripting (Is This Right?)

[BackyardStalker]

Not sure if this is the right board, so forgive me if it's not.

I made a patch to add an armor from a mod to various leveled lists using the AddItemToLeveledList function, and I just want to know if I did this right

Here's the quest containing the script:

[collapsed title=Quest][/collapsed]

And the script It controls:

[collapsed title=Script][/collapsed]

LootArmoredDuster75 is a list I made. It contains another list I made called CondArmoredDuster. The latter determines the item's condition, while the former determines the chance of finding it.

I'll ask the original mod author for permission before I upload the patch here.

[JaxFirehart]

That looks to me like it is perfect. I can't say I would have done anything differently.

[BackyardStalker]

Thanks Jax. Once I finish the other conversions I had planned, I'll ask the respective mod owners if I can upload them here.

I guess this thread can be closed now. Problem solved.

[RoyBatty]

Probably better to use NVSE and LeveledListAddForm so that people can uninstall the mod if they don't like it.

[BackyardStalker]

Thanks for the tip Roy. Here's the new script; how does it look?

[collapsed title=Script]

SCN LeveledListArmoredDusterFormListSCRIPT



Begin gameMode



If (GetGameLoaded || GetGameRestarted)

LeveledListAddForm LootArmorTier3 LootArmoredDuster75 1 1 100;

LeveledListAddForm LootArmorTier3100 LootArmoredDuster75 1 1 100;

LeveledListAddForm LootArmorTier375 LootArmoredDuster75 1 1 100;

LeveledListAddForm VendorArmorRare LootArmoredDuster75 1 1 100;

LeveledListAddForm VendorArmorRare75 LootArmoredDuster75 1 1 100;

LeveledListAddForm ConRegulatorDuster ArmoredDuster 1 1 20;

LeveledListAddForm ConRegulatorDuster ArmoredDuster 1 1 25;

LeveledListAddForm ConRegulatorDuster ArmoredDuster 1 1 30;

LeveledListAddForm ConRegulatorDuster2 ArmoredDuster 1 1 20;

LeveledListAddForm ConRegulatorDuster2 ArmoredDuster 1 1 25;

LeveledListAddForm ConRegulatorDuster2 ArmoredDuster 1 1 30;

EndIf



End

[/collapsed]

[RoyBatty]

You only need to do this once, so stop the quest which does it at the end.